#99 new
Andrew Kaspick

Fix incorrect parameter ordering to onFailure for Ajax.InPlaceEditor

Reported by Andrew Kaspick | October 1st, 2008 @ 10:20 PM

Pasted from... http://groups.google.com/group/p...

This code for the Ajax.InPlaceEditor in controls.js is supposed to show an alert when an edit fails (sending a status 400, etc.)


onFailure: function(transport, ipe) {
      alert('Error communication with the server: ' +
transport.responseText.stripTags());
    },

but transport doesn't contain the text, the ipe variable does. So this is what works instead...


onFailure: function(transport, ipe) {
      alert('Error communication with the server: ' +
ipe.responseText.stripTags());
    },

onFailure is actually triggered using the triggerCallback function which passes the ipe as the first param and the transport as the second, so in reality, the code should be...


onFailure: function(ipe, transport) {
      alert('Error communication with the server: ' +
transport.responseText.stripTags());
    },

As you can see in the code...


triggerCallback: function(cbName, arg) {
    if ('function' == typeof this.options[cbName]) {
      this.options[cbName](this, arg);
    }
  },

this.triggerCallback('onFailure', transport);

triggerCallback passes "this" as the first param, "this" being the ipe, and transport is the second param.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Attachments

Pages