#82 new
Garito

A way to know if IPE was cancelled

Reported by Garito | September 5th, 2008 @ 09:21 AM

Did you note that you couldn't know if a InPlaceEditor was raised onLeaveEditMode because the editor was cancelled or not?

There are a very easy solution

Go line 649 and add the parameter isCancelled to leaveEditMode function (and send it with the triggerCallback function at line 660)

Go line 745 and add a parameter 1 (or true) to the leaveEditMode call (there are another leaveEditMode call if user submits the editor but you don't need to modify anything)

If onLeaveEditMode has a parameter called isCancelled == 1 then the editor was cancelled if not (isCancelled is undefined) the editor was submited)

Easy, don't you think so?

Thanks and I hope you publish a new version with this change and other soon

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Pages