#41 new
pgib

Effect.Shake afterFinish not supported

Reported by pgib | July 8th, 2008 @ 08:26 PM | in 1.8.3 bugfix release

The afterFinish callback does not seem to get called when using Effect.Shake.

For a live example, see:

http://krunk.ca/Effect.Shake/

(source attached)

Comments and changes to this ticket

  • pgib

    pgib July 8th, 2008 @ 08:27 PM

    (Using script.aculo.us 1.8.1 and Prototype 1.6.0.2.)

  • Vlad

    Vlad September 18th, 2008 @ 12:06 AM

    • Tag changed from afterfinish, effect.shake, scriptaculous to afterfinish, effect.shake, scriptaculous

    Looks like the last Effect.Move in that effect does not try to inherit any events that are passed along in the options. This has worked for me - changing the last call to Effect.Move to:

    new Effect.Move(effect.element,

      Object.extend({ x: -distance, y: 0, duration: split, afterFinishInternal: function(effect) {
        effect.element.undoPositioned().setStyle(oldStyle);
      }}, options)) }}) }}) }}) }}) }});
    
    
  • ronin-15560 (at lighthouseapp)

    ronin-15560 (at lighthouseapp) November 20th, 2008 @ 08:51 PM

    • Milestone set to 1.8.3 bugfix release
  • petrm

    petrm March 26th, 2010 @ 09:22 AM

    I am sorry to confirm that in 1.8.3 is this bug too

  • petrm

    petrm December 26th, 2010 @ 01:15 PM

    • Importance changed from “” to “”

    Same in 1.9.0

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.

Source available from github
The Git repository resides at:
http://github.com/madrobby/scriptaculous

Check out the current development trunk with:
git clone git://github.com/madrobby/scriptaculous.git

As script.aculo.us 1.xx is feature-frozen, this development trunk is for bugfixes only.

New development should happen only for
script.aculo.us 2.

Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Attachments

Pages