#359 new
Quintin Siebers

Ajax.InPlaceEditor form is missing keydown event when externalControlOnly is used

Reported by Quintin Siebers | December 14th, 2012 @ 01:54 PM

The form or input element are not getting a keydown when the externalControlOnly option is used. Due to this, using the return or escape key won't do anything.

This bug is caused in line 706 in controls.js, where a set of listeners is added (or not) based on the externalControl and externalControlOnly options. However, from this set the keydown listener seems to be the exception to these checks because it (in my opinion) is always needed.

Currently fixed this in my extending class by extending the createForm() method with:

this._form.observe('keydown', this.checkForEscapeOrReturn.bind(this));

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket