#339 new
es

slider.js setValueBy || (or) operator bug

Reported by es | December 14th, 2011 @ 05:47 PM

The || or operator in setValueBy - and a few other places - evaluates to false for handleIdx when handleIdx value is 0.
The || operator evaluates correctly when the handleIdx value is a string: '' + handleIdx;

incorrectly resolves to activeHandleIdx:
values={0:0, 1:1,2:2};
handleIdx=0;
activeHandleIdx=1;
alert("setValueBy TEST using values={0:0, 1:1,2:2};\n- evaluates to activeHandleIdx when handleIdx is 0 : \nhandleIdx: " + handleIdx + "\nvalues[handleIdx]: " + values[handleIdx] + "\nreturns values[handleIdx || activeHandleIdx || 0]: " + values[handleIdx || activeHandleIdx || 0]);

correctly resolves to handleIdx:
values={0:0, 1:1,2:2};
handleIdx=""+0;
activeHandleIdx=1;
alert("setValueBy TEST using values={0:0, 1:1,2:2};\n- evaluates to handleIdx when handleIdx is string : \nhandleIdx: " + handleIdx + "\nvalues[handleIdx]: " + values[handleIdx] + "\nreturns values[handleIdx || activeHandleIdx || 0]: " + values[handleIdx || activeHandleIdx || 0]);

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Pages