#265 new
Bilgin Ibryam

Ajax.Autocompleter inserts server response to page

Reported by Bilgin Ibryam | December 27th, 2009 @ 01:00 AM

Hi,

When using Ajax.Autocompleter, if for some reason (session time out for example) the server returns an error page instead of the expected UL and LI, the autocompleter div element gets the content of response page and displayed.

I propose to check the server response before inserting into page: (there might be better ways to code this)
Also this check works fine with LocalAutocompleter.

Index: prototypejs/controls.js

--- prototypejs/controls.js +++ prototypejs/controls.js @@ -265,6 +265,13 @@ },

updateChoices: function(choices) { + var elem = new Element('div').insert(choices); + var elemType = elem.firstDescendant().tagName; + if('UL' != elemType) { + this.stopIndicator(); + this.index = 0; + return; + }

 if(!this.changed && this.hasFocus) {
   this.update.innerHTML = choices;
   Element.cleanWhitespace(this.update);

Regards,
Bilgin

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Pages