#247 new
Rafał Michalski

undeclared local variables throughout scriptaculous-1.8.3

Reported by Rafał Michalski | October 10th, 2009 @ 11:18 PM

There are buggy undeclared variables used as LOCAL to function, but referenced as GLOBAL (no var definition) in scriptaculous-1.8.3:

in builder.js:
attr: 65
attribute: 90

in dragdrop.js:
deepest: 46
i: 48
tag_name: 307

moreover dangerous use of 'with()' statement on line 547 (no w.document.body check on line 561)

in effects.js:
property: 302

in unittest.js:
specName: 549

They all appear in expression (except i in dragdrop.js):

for(item in collection)

and should be rewritten as

for(var item in collection)

If not, they may modify global object or window variable.

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket