#231 new
Taco

Ajax.Autocompleter should use KEYPRESS instead of KEYDOWN

Reported by Taco | August 4th, 2009 @ 11:23 AM

Cancelling a form submit action fails in Opera when listening to the KEYDOWN event. Instead, when KEYPRESS is used, it works cross-browser. See also:

https://prototype.lighthouseapp.com/projects/8886-prototype/tickets...

In controls.js the line

 Event.observe(this.element, 'keydown', this.onKeyPress.bindAsEventListener(this));

should therefore be

 Event.observe(this.element, 'keypress', this.onKeyPress.bindAsEventListener(this));

as the variable name already suggests :)

Testcode used:

In the body:


In the header:
document.observe("dom:loaded", function() {
new Ajax.Autocompleter("autocomplete", "autocomplete_choices", "lijstje.htm", {}); );

Comments and changes to this ticket

  • Taco

    Taco August 4th, 2009 @ 11:38 AM

    • Title changed from “Ajax.Autoloader should use KEYPRESS instead of KEYDOWN” to “Ajax.Autocompleter should use KEYPRESS instead of KEYDOWN”

    Woops, I meant Autocompleter of course. My mistake...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Pages