#225 new

Sideways scrolling not implemented in Effect.ScrollTo

Reported by sxeraverx | July 21st, 2009 @ 09:13 AM

Tested in FF3 & FF3.5;

Sideways scrolling is currently unimplemented in Effect.ScrollTo. To get this to work, I replaced Effect.ScrollTo with the following (backwards-compatible) function:

Effect.ScrollTo = function(element) {
  var options = arguments[1] || { },
  scrollOffsets = document.viewport.getScrollOffsets(),
  elementOffsets = $(element).cumulativeOffset();

  if (options.offset) elementOffsets[1] += options.offset;
  if (options.offsety) elementOffsets[1] += options.offsety;
  if (options.offsetx) elementOffsets[0] += options.offsetx;
  var sx, sy;

  new Effect.Tween(null,
    function(p){ sx = p.round(); scrollTo(sx, sy); }
  return new Effect.Tween(null,
    function(p){ sy = p.round(); scrollTo(sx, sy); }

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket