#190 new
Ludovic LANGE

Ajax.Autocompleter stopped working on all browsers [PATCH]

Reported by Ludovic LANGE | April 7th, 2009 @ 04:48 PM

Hello,

(I'm sorry but this bug report will be very short, because I didn't have the time to find if it is a regression or not, or a change in my environment. The only thing is that we upgrade prototype + scriptaculous when needed. However I had the opportunity to fix this "bug".)

On one of the websites I work on, there is an autocompleter which is rarely used. It used to work, and now we found that it doesn't. Symptoms : when we enter some text, the spinner goes spinning forever. the onComplete event is never fired.

The format of the returned data did not change that much, and the ajax.autocompleter worked with scriptaculous 1.8.0

When debugging this problem, I found that modifying the file control.js the following way helped to correct the "bug" :


--- controls.js (révision 1449)
+++ controls.js (copie de travail)
@@ -223,7 +223,7 @@
   },

   getEntry: function(index) {
-    return this.update.firstChild.childNodes[index];
+    return this.update.down().childNodes[index];
   },

   getCurrentEntry: function() {

I don't know if this is coherent or not, but it did seem in line with the other functions. It may be that there are text nodes polluting my result, but couldn't find them.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Pages