#154 new
Myles

0 range slider causes IE error

Reported by Myles | January 9th, 2009 @ 11:43 PM

If you have a slider with a range of zero (ie, from 4 to 4) then IE throws an unrecoverable error. I tracked this down to a division by zero error in the translateToPx function in slider.js. Our fix was to to test for range.end being equal to range.start and if so return 0px.

Comments and changes to this ticket

  • HCEO

    HCEO January 8th, 2010 @ 05:32 PM

    Line 152:

    translateToPx: function(value) {

    return Math.round(
      ((this.trackLength-this.handleLength)/(this.range.end-this.range.start)) *
      (value - this.range.start)) + "px";
    

    }

    -------- CHANGE TO --------

    translateToPx: function(value) {

    try {
        return Math.round(
          ((this.trackLength-this.handleLength)/(this.range.end-this.range.start)) *
          (value - this.range.start)) + "px";
    } catch(e) {
        return "0px";
    }
    

    }

  • HCEO

    HCEO January 8th, 2010 @ 05:54 PM

    Scratch that... using try does not work for some reason in IE. Use OP's suggestion of

    if ((this.range.end-this.range.start)==0) { return "0px"; }

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Tags

Pages