#109 ✓hold
Cipher

BlindDown and SlideDown Fail to render properly with padding on element

Reported by Cipher | October 29th, 2008 @ 08:45 PM

If you attempt to use Effects.BlindDown on an element with padding it extends past the normal height of the element. to see this go to the demo page, inspect the blind down demo div with firebug, add padding (something like 20px really shows it) and then try the demo... Slide down also has similar problems with the starting height being the padding...

Comments and changes to this ticket

  • ronin-15560 (at lighthouseapp)

    ronin-15560 (at lighthouseapp) November 20th, 2008 @ 05:01 PM

    • State changed from “new” to “invalid”

    Please wrap your element in an element without paddings, borders or margins.

  • Cipher

    Cipher November 20th, 2008 @ 05:54 PM

    The solution is to wrap the element in something.. are you kidding me? It's a simple thing to subtract out the padding,margins etc.... I will stop pushing this if there is a good reason, but you should not have to workaround this issue....

    I cant believe that you know this is a problem but rather than fix it, force the user to workaround it.... wow.

  • ronin-15560 (at lighthouseapp)

    ronin-15560 (at lighthouseapp) November 20th, 2008 @ 07:16 PM

    • State changed from “invalid” to “hold”

    Well, you can specify margins/paddings in more units than just pixels, so it makes it awkward to calculate the final sizes, as there's no DOM API to query the height of an element minus the paddings/borders.

    The documentation at http://github.com/madrobby/scrip... clearly states the necessity of the wrapper element.

    This is free and open source software, so instead of ranting that I don't fix it, please provide a patch for the intended behaviour.

  • Cyrus

    Cyrus April 3rd, 2009 @ 05:51 PM

    It seems that when I use a wrapper and the inner element has a margin-bottom it also doesn't render properly.

    Can you confirm this?

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Pages