#2 open
Damien Le Berrigaud

Scriptaculous: Effect.Highlight not converting 3 letters colors to 6 letters

Reported by Damien Le Berrigaud | April 22nd, 2008 @ 06:02 PM | in 1.8.3 bugfix release

I found that by creating an InPlaceEditor giving an highlight with 3 letters: '#fff'.

In firefox the Effect.Highlight will "work" and no error will be raised.

In IE I get an error when the "LeaveHover" Effect.Hightlight "update" method is triggered.

The reason is because line 496 of effects.js does a slice to get each "part" of the color. which results in having "#fff" transposed to [255, 16, NaN] (after slice and parseInt).

A simple solution is to make sure we convert 3 letters colors into 6 letters colors (see attachment for PATCH proposal).

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
<br/><b>Source available from github</b>
The Git repository resides at:
<a href="http://github.com/madrobby/scriptaculous">http://github.com/madrobby/scriptaculous</a>
<br/>Check out the current development trunk with:
<code>git clone git://github.com/madrobby/scriptaculous.git</code>
<br/>As <b>script.aculo.us 1.xx is feature-frozen</b>, this development trunk is for <b>bugfixes only</b>.
<br/>New development should happen only for
<b>script.aculo.us 2</b>.
<br/><b>Creating a bug report</b>
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, <b>alter the unit tests</b> and show through either changed or added tests how the expected behavior is not occuring.

People watching this ticket

Attachments

Pages