#684 bug
david brillard

problem when setting opacity to one with setOpacity function

Reported by david brillard | May 24th, 2009 @ 09:44 PM

When the opacity of an element is set by a CSS class, when with the setOpacity function it is set to 1, it simply erase the inline value of element's opacity.

This patch correct this behaviour by forcing the inline value to one instead of clear it.

The setOpacity unit test is also modified accordingly.

Comments and changes to this ticket

  • Tobie Langel

    Tobie Langel May 24th, 2009 @ 11:45 PM

    David, you have some white space issue in your diff. Can you please fix this ? It's really hard to code review a diff with tens on irrelevants changes. Thanks!

  • david brillard

    david brillard May 25th, 2009 @ 01:44 PM

    Hi Tobie,

    I think I have understand the problem, I force on my editor some guideline (transform tab into space, and some other things too).
    So if I'm right, I should first save all members I will modify, commit them locally, make my change and again commit the change. The diff file will then only have my modification.

    Do you think it could be the reason of the problem ??

    btw, I will check that this evening (french time) and I'll promise the diff file will be the cleaner you'll never received :))

    As I say, it's the first time I use Git, and I did not thougth this kind of problem could happend. Is there a way to not have this problem ??


  • david brillard

    david brillard May 25th, 2009 @ 09:35 PM

    Hi Tobie,
    sorry for the previous patch, it was as I said a trouble with my editor parameter that make change automatically.

    The patch is now much clear and only contained my modifications.

    thank you.

  • T.J. Crowder

    T.J. Crowder November 16th, 2009 @ 04:50 PM

    • Tag cleared.

    [responsible:none bulk edit command]

  • Tisho Georgiev

    Tisho Georgiev March 1st, 2010 @ 12:37 PM

    • Tag set to needs:tests, section:dom
    • State changed from “new” to “bug”
  • stylpe

    stylpe March 28th, 2010 @ 09:31 PM

    I can confirm this bug and it's proposed solution.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Prototype JavaScript library.

Shared Ticket Bins