#525 ✓wont_fix
avillad

JavaScriptLint validation changes

Reported by avillad | January 17th, 2009 @ 07:51 PM

I have been a happy user of Prototype for some time now and have recently been working with JavaScriptLint (http://www.javascriptlint.com) to tighten up my source files. In doing so, I ran into a number of minor issues with Prototype. This patch fixes them all and includes a JavaScriptLint config file (jsl.conf) with almost all the options turned on. The patch contains source file changes to tighten up all problems illuminated by JSL using the config file included with this patch.

I have regression tested the changes on Mac OS X 10.5.6 with Ruby 1.8.6p114 against:

  • Safari Version 3.2.1 (5525.27.1)
  • Firefox Version 2.0.0.20

I hope this patch will be accepted and made part of the next Prototype distribution so that users of lint programs such as JavaScriptLint and JSLint will not encounter validation errors when running against prototype.js. The slight increase in file size due to additional characters (explicit curly braces, semicolons, etc) can mostly be stripped out for production use with minimize programs such as JSMin.

Please let me know if there is anything else I can do.

Cheers

Comments and changes to this ticket

  • Tobie Langel

    Tobie Langel January 17th, 2009 @ 09:53 PM

    Hi,

    This has been discussed a number of times in the past already.

    I don't think the opinion of the core team has changed about it (i.e. that it's a stylistic choice).

    I'll close this as wont_fix for the time being.

    I suggest you open up a new discussion on the core mailing list about it if you wish to discuss it.

  • Tobie Langel

    Tobie Langel January 17th, 2009 @ 09:54 PM

    • State changed from “new” to “wont_fix”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Prototype JavaScript library.

Shared Ticket Bins

People watching this ticket

Attachments

Pages