#417 ✓ resolved
Igor Wasinski

Prototype 1.6.0.3 Error in IE6 (ExtJS)

Reported by Igor Wasinski | October 29th, 2008 @ 10:24 AM | in 1.6.1

I made a simple test page using ExtJS v.2.2 along with prototype 1.6.0.2 and later 1.6.0.3. I scraped some code from the examples directory for ExtJS XMLTreeGrid. When I refresh the page in IE6 it complains about "node" object not being there. It works fine in FireFox and IE7. A quick fix for me: (line 3861)


if(node){
  if (node.nodeType == Node.TEXT_NODE) node = node.parentNode;
    return Element.extend(node);
}

Not sure if this will not affect something else in general but so far it works well for me. Appreciate it if you guys could take a look at it.

Comments and changes to this ticket

  • Juriy Zaytsev

    Juriy Zaytsev October 29th, 2008 @ 10:21 PM

    • State changed from “new” to “invalid”

    It's hard to tell what the problem could be (out of the context).

    I'm closing this until we get a reproducable failing test.

    Thank you.

  • skaue

    skaue October 30th, 2008 @ 01:51 PM

    I experienced this problem as well. The problem might be in the ExtJs adapter for prototype, but from what I researched it seems the Event code (where node.nodeType is tested for uquality with Node.TEXT_NODE) have not thought about the even "unload". I did some searching on the net for what properties are available on the event "unload" to see if it at all could hold a "node"-reference, and it doesnt seem like it can. So when Firefox hits this error, it swollows it without bugging the user, while IE throws an error.

    It was so troublesome and annoying that our team ditched the entire Prototype-framework as a whole (since we started to use ExtJs). I suggest you do the same Igor. :-(

  • Juriy Zaytsev

    Juriy Zaytsev October 30th, 2008 @ 05:00 PM

    @skaue

    We will gladly look into the problem when presented with some kind of a test case.

    What do you mean by "...to see if it at all could hold a "node"-reference, and it doesnt seem like it can..."?

    Does accessing a nodeType property of an unload event object throw error?

  • skaue

    skaue October 30th, 2008 @ 08:25 PM

    Well, since I have no life, no friends, and no heartbeat..... oh wait... its back again; here it is http://skaue.com/prototype/extjs/

  • Juriy Zaytsev

    Juriy Zaytsev October 30th, 2008 @ 09:13 PM

    • State changed from “invalid” to “bug”

    @skaue

    Thanks for the test.

    unload does indeed lack the target since it fires on window (which is not a Node)

    http://www.w3.org/TR/DOM-Level-2...

    I'm marking this as a bug.

    The fix seems to be trivial:

    
    ...
    if (node && node.nodeType == Node.TEXT_NODE)
      node = node.parentNode;
    ...
    
  • skaue

    skaue October 30th, 2008 @ 11:23 PM

    Nothing like a bug with a trivial fix, am I right? ;-)

    My work is done here.

  • Tobie Langel

    Tobie Langel October 31st, 2008 @ 01:45 AM

    • Milestone set to 1.6.1
  • Andrew Dupont

    Andrew Dupont November 19th, 2008 @ 06:09 AM

    • Assigned user changed from “Andrew Dupont” to “Tobie Langel”
    • Tag changed from ie6, needs_tests, object, patched to ie6, needs_patch, needs_tests, object

    Assigning to Tobie so he can roll it into the dom.js rewrite.

  • Juriy Zaytsev

    Juriy Zaytsev February 23rd, 2009 @ 12:51 AM

    • State changed from “bug” to “resolved”

    Fixed in 91b787ae177d5f57919d416955e8d8c85e79019d

  • Tobie Langel

    Tobie Langel July 24th, 2009 @ 02:01 AM

    • Tag changed from ie6, needs_patch, needs_tests, object to ie6, needs_patch, needs_tests, section:lang

    [not-tagged:"object" tagged:"section:lang" bulk edit command]

  • Tobie Langel

    Tobie Langel July 24th, 2009 @ 02:26 AM

    • Tag changed from ie6, needs_patch, needs_tests, section:lang to ie6, missing:tests, needs_patch, section:lang

    [not-tagged:"needs_tests" tagged:"missing:tests" bulk edit command]

  • Tobie Langel

    Tobie Langel July 24th, 2009 @ 02:28 AM

    • Tag changed from ie6, missing:tests, needs_patch, section:lang to ie6, missing:patch, missing:tests, section:lang

    [not-tagged:"needs_patch" tagged:"missing:patch" bulk edit command]

  • Tobie Langel

    Tobie Langel July 24th, 2009 @ 03:36 AM

    • Tag changed from ie6, missing:patch, missing:tests, section:lang to ie6, missing:patch, needs:tests, section:lang

    [not-tagged:"missing:tests" tagged:"needs:tests" bulk edit command]

  • Tobie Langel

    Tobie Langel July 24th, 2009 @ 03:37 AM

    • Tag changed from ie6, missing:patch, needs:tests, section:lang to ie6, needs:patch, needs:tests, section:lang

    [not-tagged:"missing:patch" tagged:"needs:patch" bulk edit command]

  • Tobie Langel

    Tobie Langel July 24th, 2009 @ 12:46 PM

    • Tag changed from ie6, needs:patch, needs:tests, section:lang to needs:patch, needs:tests, section:lang

    [not-tagged:"ie6" not-tagged:"ie7" bulk edit command]

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

The Prototype JavaScript library.

Shared Ticket Bins

Pages