#3284 new
Marques Lee

positionedOffset accounts for margins incorrectly in 1.7.1

Reported by Marques Lee | May 16th, 2013 @ 10:35 PM

The logic for margin removal compensation for positionedOffset is incorrect.

The left margin should not be subtracted from the vertical coordinate, and the top margin should not be subtracted from the horizontal coordinate.

See prototype 1.7.1, lines 4050 - 4051, introduced in commit a7b2113b:

    valueL -= layout.get('margin-top');
    valueT -= layout.get('margin-left');

It should probably be:

    valueL -= layout.get('margin-left');
    valueT -= layout.get('margin-top');

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Prototype JavaScript library.

Shared Ticket Bins

People watching this ticket