#1321 new

Inefficient code in Element.Layout

Reported by Victor | March 5th, 2012 @ 04:15 PM

Code in Element.Layout to compute padding-box-height and padding-box-width is inefficient - it unnecessarily calculates padding values:

      'width': function(element) {
        // skipped
        var pLeft = this.get('padding-left'),
         pRight = this.get('padding-right');

        if (!this._preComputing) this._end();

        return bWidth - bLeft - bRight - pLeft - pRight;

      'padding-box-width': function(element) {
        var width = this.get('width'),
         pLeft = this.get('padding-left'),
         pRight = this.get('padding-right');

        return width + pLeft + pRight; // == bWidth - bLeft - bRight - pLeft - pRight + pLeft + pRight

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Prototype JavaScript library.

Shared Ticket Bins

People watching this ticket