Merge/update the old Elements.Methods.Simulated docs into source
Reported by T.J. Crowder | November 16th, 2009 @ 03:22 PM
The attached .pdoc files contain the old documentation for Elements.Methods.Simulated from the website's 1.6.0 API docs (e.g., before the inline documentation). They need to be updated and merged into the PDoc in the source.
Comments and changes to this ticket
- Tag set to claimed
I've got a build of this locally, but I'm a bit uncertain as to whether we should include the whole thing.
I don't think the
Element.Methods.Simulatednamespace itself should be documented, just the
hasAttributemethod within it.
- It creates two entries in the sidebar which link to the same
place: one under
Element.Methodsand one next to
- I don't think it really adds anything to the discussion that
couldn't just be placed in the
- Developers aren't meant to access anything in the namespace
- All of this makes it feel more like clutter than anything else.
What do you all think of this? Attached a screenshot.
I rather agree: I'm in favor of only documenting
hasAttributeas a method of
The only problem is that according to the old documentation and the actual source code, one could extend
Element.Method.Simulatedwith methods he'd like to have on extended elements if absent.
I don't know if we still want to support it though, I think that's something that should be discussed...
I hadn't thought of that. If we keep it documented I think we should state its purpose in more developer-centric terms:
Element.Methods.Simulatedprovides you with a place to put methods that should only be added to
Element's if not already present in the native browser
And some examples could be added. On a side note, is it possible to ensure that
Element.Methods.Simulateddoesn't show up twice in the side navigation?
- Tag changed from claimed to patched
Patched and committed here:
The only reason I suggested a discussion was the fact that it's actually documented in the old documentation, but I don't think anybody ever extended
@Dan: I'll manually remove
Element.Method.Simulateddocumentation from your commit, don't bother creating a new one...
- State changed from port to fixed_in_branch
(from [c5ac98d3a11d62935e4576f3f11460646e2911f1]) doc: Merge/update the old Element.hasAttribute docs into source [#90 state:fixed_in_branch] http://github.com/samleb/prototype/commit/c5ac98d3a11d62935e4576f3f...
- State changed from fixed_in_branch to resolved
- Importance changed from to
(from [e4503ee9912be5abff287b88f7c27a9f43632fdd]) Handle cases where
document.documentElementis passed into Element#getOffsetParent. Fixes IE errors with many layout/positioning methods. [#90 state:resolved] (Padraig Kennedy, Andrew Dupont) http://github.com/samleb/prototype/commit/e4503ee9912be5abff287b88f...