#49 ✓resolved
T.J. Crowder

Dropping non-ASCII chars and trailing whitespace from the source

Reported by T.J. Crowder | March 23rd, 2009 @ 11:59 AM

I'm getting started on some doc tickets, which of course means editing the source files now that we have inline docs (yes!). I found a couple of things grabbing the latest source:

  1. We have some non-ASCII chars in comments in the source (some m-dashes and curly apostrophes -- three-byte Unicode entities). While this is perfectly valid UTF-8, Tobie and I were talking about it and he felt we probably should remove them.

  2. There is trailing whitespace on a lot of lines that some editors (like mine) will automatically trim, causing false diffs on patches.

  3. templates/html/assets/javascripts/code_highlighter.js has CRLFs instead of LFs, consequently doing a pull and then committing anything will result in a patch for that file.

Barring objection, tomorrow morning I'll pull the latest, convert the curly apostrophes to old-fashioned ASCII ones, convert the m-dashes to — entities, trim trailing whitespace, and post a patch to this ticket (which will automatically include the CRLF->LF thing) with only those changes, nothing substantive.

Then I'll get on with some real work. :-)

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Shared Ticket Bins

Tags

Pages