#15 new
Christophe Porteneuve

A5->A6 regression in S2.UI.Autocompleter

Reported by Christophe Porteneuve | July 12th, 2010 @ 10:17 PM

Hey there!

A5->A6 changed the click handler of S2.UI.Menu to mouseup, which introduces an issue with its use in S2.UI.Autocompleter. This latter one expects ui:menu:selected to fire, which happens on mouseup, but then mousedown on menu will trigger the autocompleter's blur handler, which closes the menu, preventing the mouseup.

Net result: autocompletion is perfectly keyboard-accessible… and ignores mouse clicks.

So perhaps reverting to mouseup would be nice? In my own instance of S2 (in the project I use this on), I added S2.UI.Menu an option so I can ask it to go with mousedown instead of its new default mouseup. I then use this option when instantiating it from S2.UI.Autocompleter's initialize.

FWIW, I also have a tiny S2.UI.Autocompleter.Ajax class that just overrides setChoices and initialize


No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป


People watching this ticket