#11 new
Diego Perini

Errors compressing S2 with packer 3

Reported by Diego Perini | June 14th, 2010 @ 02:41 AM

A couple of missing semicolon prevent us minify and compress the whole thing :)

--- s2.js   2010-03-30 14:24:00.000000000 +0200
+++ s2.js.OK    2010-06-14 02:20:08.000000000 +0200
@@ -4337,7 +4337,7 @@
     element.style.marginTop = (element._oDims[1]-element.offsetHeight)/2+'px';
     return element;
   };
-  else transform = function(element){ return element; }
+  else transform = function(element){ return element; };

   Element.addMethods({ transform: transform });
 })();
@@ -4386,7 +4386,7 @@

     this.overlay = S2.viewportOverlay();
     if (this.options.overlayClassName)
-      this.overlay.addClassName(this.options.overlayClassName)
+      this.overlay.addClassName(this.options.overlayClassName);
     else
       this.overlay.setStyle({backgroundColor: '#000', opacity: '0.9'});
     $$('body')[0].insert(this.overlay);

I just submitted a ticket in Prototype for similar things. The objective is being able to minify/compress both Prototype and S2 (and maybe have them in the same file).

Thanks,

Diego

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

http://github.com/madrobby/scripty2

People watching this ticket

Pages