Changeset [a65396e1a1ab5ff5e31b8c9c2c6e6feced3dadd8] by Thomas Fuchs

April 18th, 2011 @ 08:21 PM

Merge pull request #27 from rafalwrzeszcz/scripty2


There is a problem with S2.FX.Parallel that it doesnt invoke methods on aggregated effects like start() or cancel(), so its callbacks wont be executed. Whats more, effects can even not be completed, since cancel() is not called, which causes teardown() to not be called.

I believe those are two methods that have to be called on sub-effects to make them fully functional (start() marks effects as "running" as cancel() wont take any effect if status is not "running") - i dont see any need to call finish() on sub-effects (but if it would be needed, then canel() should not be called - only one of them should be called by parallel aggregator).
https://github.com/madrobby/scripty2/commit/a65396e1a1ab5ff5e31b8c9...

Committed by Thomas Fuchs

  • M src/effects/parallel.js
New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

http://github.com/madrobby/scripty2