15553 2 false 2009-02-11T22:19:35+01:00 15553 32011 5 sprockets-should-integrate-the-yui-compressor 1 8888 discuss compression feature suggestion 2009-11-13T16:39:14+01:00 46611 jwheare Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 Sprockets should offer a feature to pass the resulting concatenation through the [YUI Compressor](http://developer.yahoo.com/yui/compressor/). YUI Compressor is distributed as an 830 KB .jar and requires Java >= 1.4 to run. Shelling out to it from Sprockets is easy; the difficult problem, as I see it, is figuring out how to a) bundle the compressor with Sprockets or b) make use of existing installations of the compressor with minimal configuration. Sprockets should offer a feature to pass the resulting concatenation through the [YUI Compressor](http://developer.yahoo.com/yui/compressor/). YUI Compressor is distributed as an 830 KB .jar and requires Java >= 1.4 to run. Shelling out to it from Sprockets is easy; the difficult problem, as I see it, is figuring out how to a) bundle the compressor with Sprockets or b) make use of existing installations of the compressor with minimal configuration. <div><p>Sprockets should offer a feature to pass the resulting concatenation through the <a href="http://developer.yahoo.com/yui/compressor/">YUI Compressor</a>.</p> <p>YUI Compressor is distributed as an 830 KB .jar and requires Java &gt;= 1.4 to run. Shelling out to it from Sprockets is easy; the difficult problem, as I see it, is figuring out how to a) bundle the compressor with Sprockets or b) make use of existing installations of the compressor with minimal configuration.</p></div> 15553 0 Sprockets should offer a feature to pass the resulting concatenation through the [YUI Compressor](http://developer.yahoo.com/yui/compressor/). YUI Compressor is distributed as an 830 KB .jar and requires Java >= 1.4 to run. Shelling out to it from Sprockets is easy; the difficult problem, as I see it, is figuring out how to a) bundle the compressor with Sprockets or b) make use of existing installations of the compressor with minimal configuration. <div><p>Sprockets should offer a feature to pass the resulting concatenation through the <a href="http://developer.yahoo.com/yui/compressor/">YUI Compressor</a>.</p> <p>YUI Compressor is distributed as an 830 KB .jar and requires Java &gt;= 1.4 to run. Shelling out to it from Sprockets is easy; the difficult problem, as I see it, is figuring out how to a) bundle the compressor with Sprockets or b) make use of existing installations of the compressor with minimal configuration.</p></div> false 2009-02-11T22:19:36+01:00 15553 --- {} 5 sprockets-should-integrate-the-yui-compressor 0 8888 new feature 2009-02-11T22:21:51+01:00 15553 Sam Stephenson Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 0 I wonder if we can just download the YUI compressor with an extra, optional step and install it into the sprockets lib folder. As it requires Java it might not run everywhere (This is a sentence I long wanted to use). <div><p>I wonder if we can just download the YUI compressor with an extra, optional step and install it into the sprockets lib folder.</p> <p>As it requires Java it might not run everywhere (This is a sentence I long wanted to use).</p></div> false 2009-02-11T22:41:23+01:00 15553 --- {} 5 sprockets-should-integrate-the-yui-compressor 0 8888 new feature 2009-02-11T22:41:25+01:00 15560 Thomas Fuchs Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 0 How about something like the attached? This makes a path to the YUI jar a Secretary option (so you don't have to distribute the jar, and you get all the baked-in Secretary config goodness), and makes the main calls to secretary use "processed" instead of "concatenation" which is really just a naming thing - if the YUI jar is set, it will try to minify the concatenation, if not it will just give the concatenation. For the minify method there may be a cleaner way than a popen that just assumes "java" is on the path. <div><p>How about something like the attached? This makes a path to the YUI jar a Secretary option (so you don't have to distribute the jar, and you get all the baked-in Secretary config goodness), and makes the main calls to secretary use "processed" instead of "concatenation" which is really just a naming thing - if the YUI jar is set, it will try to minify the concatenation, if not it will just give the concatenation. For the minify method there may be a cleaner way than a popen that just assumes "java" is on the path.</p></div> false 2009-02-19T23:28:34+01:00 15553 --- {} 5 sprockets-should-integrate-the-yui-compressor 0 8888 new feature 2009-02-19T23:28:39+01:00 29461 Ryan Baumann Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 1 Ryan, that approach seems OK to me. I'd also suggest that the path to the YUI can be set by environment variable — though a command-line argument would take precedence. <div><p>Ryan, that approach seems OK to me. I'd also suggest that the path to the YUI can be set by environment variable &#8212; though a command-line argument would take precedence.</p></div> false 2009-02-21T03:59:32+01:00 15553 --- :state: new 5 sprockets-should-integrate-the-yui-compressor 0 8888 open feature 2009-02-21T03:59:36+01:00 15556 Andrew Dupont Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 1 Here's a slightly improved version of the patch. The YUI path can now be set by an environment variable, and Concatenation.save_to has been pulled out into Secretary (would also affect sprockets-rails in a few places). The minify method has been made a little bit more robust. A stub conditional test (using the YUI path environment variable) for minification has been dropped in. <div><p>Here's a slightly improved version of the patch. The YUI path can now be set by an environment variable, and Concatenation.save_to has been pulled out into Secretary (would also affect sprockets-rails in a few places). The minify method has been made a little bit more robust. A stub conditional test (using the YUI path environment variable) for minification has been dropped in.</p></div> false 2009-02-22T02:33:03+01:00 15553 --- {} 5 sprockets-should-integrate-the-yui-compressor 0 8888 open feature 2009-02-22T02:33:05+01:00 29461 Ryan Baumann Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 2 Thanks Ryan. Good call on moving Concatenation#save_to into Secretary. I'm not so keen on the name Secretary#processed. <div><p>Thanks Ryan. Good call on moving Concatenation#save_to into Secretary. I'm not so keen on the name Secretary#processed.</p></div> false 2009-02-22T20:01:07+01:00 15553 --- {} 5 sprockets-should-integrate-the-yui-compressor 0 8888 open feature 2009-02-22T20:01:09+01:00 15553 Sam Stephenson Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 2 false 2009-02-22T20:17:05+01:00 15553 --- :state: open 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss feature 2009-02-22T20:17:08+01:00 15553 Sam Stephenson Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 15553 2 false 2009-02-22T20:23:30+01:00 15553 --- :milestone: 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss feature 2009-02-22T20:23:31+01:00 15553 Sam Stephenson Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 15553 2 As an alternative, could Sprockets use a Ruby javascript compressor? Say, something like Douglas Crockford's: http://www.crockford.com/javascript/jsmin.rb <div><p>As an alternative, could Sprockets use a Ruby javascript compressor? Say, something like Douglas Crockford's: <a href="http://www.crockford.com/javascript/jsmin.rb">http://www.crockford.com/javascr...</a></p></div> false 2009-03-18T03:25:52+01:00 15553 --- {} 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss feature 2009-03-18T03:25:55+01:00 40611 Thomas Bukowski Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 15553 2 I agree with Thomas Bukowski that YUI should not be the only option. I think Ryan's patch would be a good solution, as long as it does not only apply to YUI. It could be a configuration option that allows you to pass the output file to any shell command - this broadens the usage of the option beyond compression. @@@ ruby Sprockets::Secretary.new( :post_process_command => 'java -jar /path/to/yui -o #{file} #{file}' ) @@@ An alternative approach could be to provide various compressors as *plugins* in the form of gems (sprockets-compressor-yui, sprockets-compressor-jsmin etc.) - each of these gems would contain the compressor script/binary and provide configuration options in the Secretary class to enable the compressor. I have used something similar to the latter approach in [a Rails plugin](http://github.com/logandk/sprockets-compressor/tree/master) that enables compression through YUI by overriding the `save_to` method (a temporary solution until Sprockets supports compression). <div><p>I agree with Thomas Bukowski that YUI should not be the only option. I think Ryan's patch would be a good solution, as long as it does not only apply to YUI. It could be a configuration option that allows you to pass the output file to any shell command - this broadens the usage of the option beyond compression.</p> <pre><code class="ruby"> Sprockets::Secretary.new( :post_process_command =&gt; 'java -jar /path/to/yui -o #{file} #{file}' ) </code></pre> <p>An alternative approach could be to provide various compressors as <em>plugins</em> in the form of gems (sprockets-compressor-yui, sprockets-compressor-jsmin etc.) - each of these gems would contain the compressor script/binary and provide configuration options in the Secretary class to enable the compressor.</p> <p>I have used something similar to the latter approach in <a href="http://github.com/logandk/sprockets-compressor/tree/master">a Rails plugin</a> that enables compression through YUI by overriding the <code>save_to</code> method (a temporary solution until Sprockets supports compression).</p></div> false 2009-04-20T12:43:07+02:00 15553 --- :tag: feature 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss compression feature suggestion 2009-04-20T12:43:11+02:00 54591 Logan Raarup Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 15553 2 I like the idea of gem-based plugins, which would remove the hassle of configuring. Install the plugin, and you've a command line option available for compression. We'd need a "API" in Sprockets for registering a plugin command-line option, and we can just use Ruby to alias/override methods in the plugins. <div><p>I like the idea of gem-based plugins, which would remove the hassle of configuring. Install the plugin, and you've a command line option available for compression. We'd need a "API" in Sprockets for registering a plugin command-line option, and we can just use Ruby to alias/override methods in the plugins.</p></div> false 2009-04-20T13:08:49+02:00 15553 --- {} 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss compression feature suggestion 2009-04-20T13:08:50+02:00 15560 Thomas Fuchs Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 15553 2 I'm not sure it's worth it to support several minifiers. As Sam already wrapped up YUI Compressor as a gem, I decided to try integrate it and it works like a charm. The patch consists in two commits: http://github.com/samleb/sprockets/tree/minification <div><p>I'm not sure it's worth it to support several minifiers.<br> As Sam already wrapped up YUI Compressor as a gem, I decided to try integrate it and it works like a charm.</p> <p>The patch consists in two commits: <a href= "http://github.com/samleb/sprockets/tree/minification">http://github.com/samleb/sprockets/tree/minification</a></p></div> false 2009-10-23T18:42:21+02:00 15553 --- {} 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss compression feature suggestion 2009-10-23T18:42:25+02:00 17913 Samuel Lebeau Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 15553 2 Thanks to @jwheare I fixed support for minification in `nph-sprockets.cgi`. The third commit is available on my minification branch here : http://github.com/samleb/sprockets/commit/fc8fdff18e0d86969da4517728f57e696be4cce5 I forgot to notice that you can use either `:minify => true` which uses ruby-yui-compressor gem default options, or give an explicit hash of options like `:minify => { :munge => true }`. What do you guys think about integrating this ? <div><p>Thanks to @jwheare I fixed support for minification in <code>nph-sprockets.cgi</code>.<br> The third commit is available on my minification branch here : <a href= "http://github.com/samleb/sprockets/commit/fc8fdff18e0d86969da4517728f57e696be4cce5"> http://github.com/samleb/sprockets/commit/fc8fdff18e0d86969da451772...</a></p> <p>I forgot to notice that you can use either <code>:minify =&gt; true</code> which uses ruby-yui-compressor gem default options, or give an explicit hash of options like <code>:minify =&gt; { :munge =&gt; true }</code>.</p> <p>What do you guys think about integrating this ?</p></div> false 2009-11-13T16:08:09+01:00 15553 --- {} 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss compression feature suggestion 2009-11-13T16:08:13+01:00 17913 Samuel Lebeau Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 15553 2 +1 Samuel's patch. This would be great to have in the main gem. <div><p>+1 Samuel's patch. This would be great to have in the main gem.</p></div> false 2009-11-13T16:39:12+01:00 15553 --- {} 32011 5 sprockets-should-integrate-the-yui-compressor 0 8888 discuss compression feature suggestion 2009-11-13T16:39:14+01:00 46611 jwheare Sam Stephenson Sam Stephenson http://prototype.lighthouseapp.com/projects/8888/tickets/5 1.1.0 a11ea41137cd4a66ab520be7397828b711540806 text/plain 2009-02-19T23:28:34+01:00 yui-sketch.patch 90885 2799 29461 http://prototype.lighthouseapp.com/attachments/90885/yui-sketch.patch a40d243900d55e5b6334561ce4928e1d0f1f1a93 text/plain 2009-02-22T02:33:04+01:00 yui-compressor.patch 91495 6190 29461 http://prototype.lighthouseapp.com/attachments/91495/yui-compressor.patch