Unable to call chained .update('') on object returned from Builder.node('div') in IE7
Reported by Rob Sterner | August 28th, 2008 @ 05:14 PM
I came across this issue trying to use Builder from within IE7 - the problem didn't occur with Firefox 3, Safari 3, Camino -- you get where I'm going with this.
code:
Builder.node('div', {id:this.options.previousButtonId, className: 'previous'}).update(' ');
I was getting a:
Microsoft JScript runtime error: Object doesn't support this property or method
error. I could construct the new node in a debugger then call .update() on its contents, trying to chain the method calls failed.
Patch seems to be to Prototypify the returned value from Builder.node():
return $(element);
rather than:
return element;
Should I bother submitting a patch/diff for this?
Comments and changes to this ticket
-
Rob Sterner August 28th, 2008 @ 07:18 PM
Looks like this is a dupe of:
http://prototype.lighthouseapp.c...
Sorry for the dupe submission, however, I'm thinking that extending the returned element from Builder.node by default is probably a better idea given that it's how most of Prototype works already. Seems cleaner than the proposed solution from #71.
-
Thomas Fuchs August 28th, 2008 @ 08:08 PM
- → State changed from “new” to “resolved”
(from [9d30ad9ad7d7ebdaa6e6d5f3bd331b47c356070b]) Fix that Builder.node did not return extended elements on IE. [#71 state:resolved] [#77 state:resolved] http://github.com/madrobby/scrip...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
Source available from github
The Git repository resides at:
http://github.com/madrobby/scriptaculous
Check out the current development trunk with:
git clone git://github.com/madrobby/scriptaculous.git
As script.aculo.us 1.xx is feature-frozen, this development trunk is for bugfixes only.
New development should happen only for
script.aculo.us 2.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
