Enhancement in Autocompleter.Local: Also accepts a hash of autocomplete options
Reported by Mridul Pathak | July 14th, 2008 @ 08:19 AM
Currently Autocompleter.Local accepts an array of autocomplete options. This patch allows it to accept a hash as well. The values in the hash act as autocomplete options rendered through li and keys act as the id of the li.
This is my first patch here. I followed the way suggested to create the patch. Please let me know if I did anything wrong.
Looking forward to your comments on this patch.
Comments and changes to this ticket
-
Mridul Pathak July 14th, 2008 @ 08:24 AM
Currently Autocompleter.Local accepts an array of autocomplete options. This patch allows it to accept a hash as well. The values in the hash act as autocomplete options rendered thorugh and keys act as the id of the.
This is my first patch here. I followed the way suggested to create the patch. Please let me know if I did anything wrong.
Looking forward to your comments on this patch.
-
-
Mridul Pathak July 15th, 2008 @ 08:49 AM
Added a functional test, uploading the patch for that. Thanks Thomas for helping a newbie. :)
-
GlennFleishman July 15th, 2008 @ 11:04 PM
I have updated the wiki documentation to be clear that hashing doesn't work with Ajax.Autocompler in the current 1.8.1 release that's life on the site for download. I'm noting this here so that I or someone else can update the wiki to remove the bug/errata note from the wiki when this is fixed in a shipping release.
-
Mridul Pathak August 19th, 2008 @ 07:55 AM
Please let me know if anything is needed for this ticket. Also I am not aware of the process community follows to get these changes in the main repository, or releasing them. Please let me know about the process as well.
-
Mridul Pathak October 10th, 2008 @ 08:55 AM
Hi,
Can anyone please help me with the process followed to commit the changes in the script.aculo.us repository and release them, after a ticket has been created? I am new to this community and I am not aware of the process well. We are using script.aculo.us libraries in our project and our project requires this enhancement. And we want to use this enhancement only if its there in the new release of script.aculo.us. And the reason is that we want to use the libraries as they are without any customization, so that we can easily upgrade to the new versions. Please let me know your plans about this enhancement, I have few more patches to contribute and I'll be happy to do the same once I am aware of the process. -
Thomas Fuchs October 10th, 2008 @ 11:05 AM
Hey Mridul!
No worries, I'll review it and add it if appropriate! :)
Best, Thomas
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
Source available from github
The Git repository resides at:
http://github.com/madrobby/scriptaculous
Check out the current development trunk with:
git clone git://github.com/madrobby/scriptaculous.git
As script.aculo.us 1.xx is feature-frozen, this development trunk is for bugfixes only.
New development should happen only for
script.aculo.us 2.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
