script.aculo.us

Comments and changes to this ticket

• 

  Thomas Fuchs June 12th, 2008 @ 08:47 AM

  • → Assigned user changed from “Thomas Fuchs” to “Christophe Porteneuve”
• 

  crankshaft June 18th, 2008 @ 03:25 PM

  I couldn't afford waiting any longer, so I had to fix this myself. :)

  The problem lies between lines 631-636 in control.js:

        var options = Object.extend({ evalScripts: true }, this.options.ajaxOptions);
        Object.extend(options, {
          parameters: params,
          onComplete: this._boundWrapperHandler,
          onFailure: this._boundFailureHandler
        });
  

  Now, if this.options.ajaxOptions['onComplete'] != null, it gets written over when extending the options object. The solution is to "merge" the user's custom onComplete functions with this._boundWrapperHandler. I don't know if there's a clean way to do this, but I solved it like this:

        var options = Object.extend({ evalScripts: true }, this.options.ajaxOptions);
        
        // patch begins
        var oc = new Function();
        for (var i in options) {
        	if (i == "onComplete") {
        		oc = options[i];
        	}
        }
        Object.extend(options, {
          parameters: params,
          onComplete: function() { this._boundWrapperHandler(); oc(); }.bind(this),
          onFailure: this._boundFailureHandler
        });
        // patch ends