Remove inline style on element when Effect.Highlight finishes
Reported by Olly Headey | May 22nd, 2008 @ 11:39 AM
Currently Effect.Highlight leaves an inline "background-color" style on the destination element once it has completed. This causes a problem if some other Javascript method needs to control the background colour of that element (in my case, table row hover).
Attached is a patch which removes this inline style once the highlight has finished. I'm new to Scriptaculous so I'm not sure if this fix is good practice or not, but it certainly works.
Comments and changes to this ticket
-
Olly Headey May 22nd, 2008 @ 11:41 AM
- no changes were found...
-
devilabit August 14th, 2008 @ 06:03 PM
- → Tag changed from “” to “effect.highlight patch scriptaculous”
I have had issues with this also. The inline style also overrides the css.
Simply changing
if (!this.options.restorecolor) { this.options.restorecolor = this.element.getStyle('background-color'); }
to
if (!this.options.restorecolor) { this.options.restorecolor = (this.element.style.backgroundColor ? this.element.getStyle('background-color') : null); }
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
Source available from github
The Git repository resides at:
http://github.com/madrobby/scriptaculous
Check out the current development trunk with:
git clone git://github.com/madrobby/scriptaculous.git
As script.aculo.us 1.xx is feature-frozen, this development trunk is for bugfixes only.
New development should happen only for
script.aculo.us 2.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post a an example that shows off the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Thomas Fuchs