#285 css selection fails when checking for attr presence - Prototype

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:id	tickets sorted by id (creation time)
Combine keywords for powerful searching.
Use advanced searching »

#285 bug

css selection fails when checking for attr presence

Reported by leiyou | August 16th, 2008 @ 02:19 PM | in 1.6.0.4

this happens for attrs with that contain -

an example would be

$$('[a-b]')

Juriy Zaytsev August 16th, 2008 @ 05:07 PM
- → Tag changed from “element selector” to “needs_patch needs_tests selector”
- → Milestone changed from “” to “1.6.1”
- → State changed from “new” to “bug”
- → Assigned user changed from “” to “Juriy Zaytsev”
Looks like "_" works but "-" doesn't.
John-David Dalton August 17th, 2008 @ 01:47 AM
could be a regexp thing [a-b] creates a character range in regexp
leiyou August 17th, 2008 @ 04:50 AM
seems so, seems to do with this attrPresence: /^[([\w]+)]/

2008/8/17 Lighthouse support@lighthouseapp.com
John-David Dalton August 17th, 2008 @ 04:57 AM
ahh they would need to change it to :
```
attrPresence: /^[([\w-]+)]/
```
This probably effects other areas as well I know they like to use a character class [\w] a lot.
Juriy Zaytsev October 7th, 2008 @ 06:00 AM
- → Tag changed from “needs_patch needs_tests selector” to “patched selector tested”
- → Milestone changed from “1.6.1” to “1.6.0.4”
- 0004-Fix-selector-to-match-elements-with-attributes-conta.patch 2.4 KB
Dror Kessler November 10th, 2008 @ 09:03 AM
- → Tag cleared.
Note that the patch calls for [\w-]. This is risky ... since the - character is a special character within a character class.

better use [\w-]