Prototype

Comments and changes to this ticket

• 

  John-David Dalton July 7th, 2008 @ 03:42 PM

  • → Tag changed from “ajax.request ie7” to “ajax.request ie7 needs_patch needs_tests”
  • → Milestone changed from “” to “1.6.1”
  • → State changed from “new” to “bug”
  • → Title changed from “Ajax.Request considers HTTP 204 a failure under IE only” to “Ajax.Request IE responds with 1223 instead of 204”
  • → Assigned user changed from “” to “Tobie Langel”
• 

  Adam Nielsen July 8th, 2008 @ 02:35 AM

  Here is a change to the getStatus() function which fixes the problem for me. I only have IE7 available to test with, so I don't know whether the userAgent condition needs to be changed to capture other versions as well - but it will certainly fix the problem for IE7 users.

    getStatus: function() {
      try {
        if (navigator.userAgent.match(/MSIE 7.0/) && this.transport.status == 1223)
          return 204; // Special case where IE7 returns 1223 for HTTP 204 response
        else
          return this.transport.status || 0;
      } catch (e) { return 0 }
    },
  

• 

  John-David Dalton July 8th, 2008 @ 04:22 AM

  I think we can do this without a browser sniff.

  Here is how jQuery handles it:

  
    // Determines if an XMLHttpRequest was successful or not
    httpSuccess: function( r ) {
      try {
        // IE error sometimes returns 1223 when it should be 204 so treat it as success, see \#1450
        return !r.status && location.protocol == "file:" ||
          ( r.status >= 200 && r.status < 300 ) || r.status == 304 || r.status == 1223 ||
          jQuery.browser.safari && r.status == undefined;
      } catch(e){}
      return false;
    },
  

• 

  Adam Nielsen July 8th, 2008 @ 09:25 AM

  That could be fine, but you would probably want to apply the change to the getStatus() function, otherwise getStatus() will return 204 on FF and 1223 on IE. Likewise fudging the return value of getStatus() should make on204() work correctly.

  The only thing that makes me wonder is this post from the prototype mailing list which seems to indicate 1223 is actually a valid error code.

  Having said that perhaps misreporting an infrequent error is better than constantly misreporting a successful request as a failure.

    getStatus: function() {
      try {
        if (this.transport.status == 1223)
          return 204; // Special case where IE7 returns 1223 for HTTP 204 response
        else
          return this.transport.status || 0;
      } catch (e) { return 0 }
    },
  

• 

  John-David Dalton July 8th, 2008 @ 02:24 PM

  Ya I was just showing you how they handle it without a sniff.

• 

  Adam Nielsen July 9th, 2008 @ 01:55 AM

  Ah ok, fair enough. I only put the browser sniff in there in case another browser really does return that code as a legitimate error, but I guess that's probably not too likely anyway.

• 

  John-David Dalton September 4th, 2008 @ 04:26 PM

  • → State changed from “bug” to “duplicate”

  duplicate of http://prototype.lighthouseapp.com/projects/8886/tickets/129-ie-mangles-http-response-status-code-204-to-1223