Prototype

Comments and changes to this ticket

• 

  Nick Stakenburg June 30th, 2008 @ 02:49 PM

  I don't think it's that useful. You can use Element#toggle or if it's about having a one liner use something like this.

  $(element)[$('checkbox').checked ? 'show' : 'hide']();
  

• 

  John-David Dalton June 30th, 2008 @ 04:31 PM

  I agree with Nick on this. You can always add something like that to your own projects via the Element.addMethods though.

  I think the name of the method would have to be tweaked.

  You might even do something like:

  
  Element.Methods.toggle = Element.Methods.toggle.wrap(proceed, element, conditional) {
    element = $(element);
    if (arguments.length === 3) {
      if (Object.isFunction(conditinal))
        conditional = conditional.call(element);
      return element[ conditional ? 'show' : 'hide' ]();
    }
    return proceed(element);
  };
  
  Element.addMethods();
  
  

• 

  Andrew Dupont June 30th, 2008 @ 05:48 PM

  • → State changed from “new” to “enhancement”
  • → Milestone changed from “” to “1.6.1”

  We had talked about adding boolean arguments to Element#toggle and Element#toggleClassName that would enable this. It'd be backwards-compatible. I am in favor of it, but let's talk about it again when 1.6.1 nears.

• 

  Juriy Zaytsev June 30th, 2008 @ 06:16 PM

  This is actually useful.

  I use similar method all the time (http://github.com/kangax/protoli...).

  +1 (by 1.6.1)

• 

  John-David Dalton June 30th, 2008 @ 06:39 PM

  • → State changed from “enhancement” to “new”
  • → Milestone cleared.

  cool :)

• 

  dobby June 30th, 2008 @ 07:14 PM

  The proposal with the extra optional boolean in toggle is really nice, it's backwards compatible and doesn't add an extra method. I like it.

  I disagree that the following syntax

  @@javascript

  $(element)[$('checkbox').checked ? 'show' : 'hide']();

  @@

  It is very ugly and actually proves that internally prototype needs the function. If the toggle with boolean would exist you could replace the example with a call to the toggle method.

  Adding your own method for something as simple and obvious as this functionality seems clumsie, prototype is all about making it easy to manipulate the dom. I agree that special methods specific to your project should not integrated into the core prototype lib but this is not the case in this very generic method.

• 

  John-David Dalton June 30th, 2008 @ 07:15 PM

  • → Assigned user changed from “” to “Juriy Zaytsev”
  • → State changed from “new” to “enhancement”
  • → Milestone changed from “” to “1.6.1”

  oops donno why it cleared mileston and state...

  I think it should allow a conditional method to be passed as well (via my example)