Make WebKit branch of $A use a better NodeList detection.
Reported by John-David Dalton | June 24th, 2008 @ 07:15 PM | in 1.6.0.3
While it is still unclear why there is a need for a branched $A for WebKit, the NodeList detection in it could be improved.
Garrett Smith as pointed out that we shouldn't rely on a Function toString for this detection.
I have patched this to do a more accurate check.
I got the check from google-doctype.
Eventually I would like to see an Object.isNodeList method (maybe for 1.6.1).
Comments and changes to this ticket
-
John-David Dalton June 24th, 2008 @ 07:15 PM
- → State changed from “new” to “enhancement”
-
John-David Dalton June 24th, 2008 @ 07:18 PM
- → State changed from “enhancement” to “bug”
Also a side effect of using the Object.isFunction (newly reworked by Juriy) is that it would block all iterators that are functions from the WebKit branch. My patch would resolve that as well because it doesnt use Object.isFunction. (thanx Juriy for the headsup)
-
John-David Dalton June 24th, 2008 @ 10:52 PM
- → Assigned user changed from “John-David Dalton” to “Tobie Langel”
-
GitHub Robot July 17th, 2008 @ 08:33 PM
- → State changed from “bug” to “resolved”
- → Tag changed from “” to “patched”
(from [d1c6b0199bfe6d1ef13cf207455307a424d05393]) Improve NodeList detection for Safari's $A function. [#187 state:resolved]
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
The Prototype JavaScript library.
Tobie Langel