Prototype

Comments and changes to this ticket

• 

  John-David Dalton June 24th, 2008 @ 06:04 PM

  • → State changed from “new” to “enhancement”
• 

  John-David Dalton June 24th, 2008 @ 06:06 PM

  added patch

• 

  John-David Dalton June 24th, 2008 @ 09:54 PM

  • → State changed from “enhancement” to “invalid”

  display may be set to "inherit" and thus the use of Element#getStyle is justified.

  http://www.w3.org/TR/REC-CSS2/visuren.html#display-prop

• 

  John-David Dalton June 24th, 2008 @ 09:54 PM

  • → State changed from “invalid” to “bug”
• 

  John-David Dalton June 24th, 2008 @ 09:56 PM

  • → Title changed from “Make Element#visible use Element#getStyle so it can detect inherited values” to “Make Element#visible work with display:inherit”

  • 0003-Make-Element-visible-work-with-display-inherit.patch 1.3 KB
• 

  Tobie Langel June 26th, 2008 @ 06:32 PM

  • → State changed from “bug” to “invalid”
  • → Tag changed from “” to “patched”

  This isn't possible for the reasons described here: http://tobielangel.com/2006/12/3...

• 

  John-David Dalton June 26th, 2008 @ 08:19 PM

  • → Milestone changed from “1.6.0.3” to “1.6.1”
  • → State changed from “invalid” to “bug”

  I don't think your reasons described in the article are relevant to this bug (I totally might have missed the reasons though).

  I did test Element.getStyle and it returns "inherit" in Firefox.

  SO this patch would require Element.getStyle to be fixed first.

  <div id="pappa-bear" style="display:inline;">
    <div id="baby-bear" style="display:inherit">
  </div>
  

  
  var element = $('baby-bear'),
   value, style = 'display';
  
  // currently IE ignores "inherit" and makes display "block", so this is more of a future proof IE check
  if (element.parentNode && element.getStyle('display') == 'inherit')
    value = element.currentStyle ? element.up().getStyle(style) :
    (document.defaultView.getComputedStyle(element, null) || {}).display;
  else value = element.getStyle(style);
  
  
  //works in Firefox, Opera, and Safari
  alert(value); //inline
  

• 

  John-David Dalton June 26th, 2008 @ 08:29 PM

  • → Title changed from “Make Element#visible work with display:inherit” to “Make Element#getStyle translate "inherit" and Element#visible work with display:inherit”
  • → Tag cleared.
• 

  Juriy Zaytsev June 27th, 2008 @ 12:20 AM

  What if we change #show to accept an optional "display value" parameter, and when not present, default to a current implementation?

  element.show('inline'); // sets element's style.display to "inline"
  

• 

  John-David Dalton June 27th, 2008 @ 02:17 AM

  Juriy I am not sure if that is in the scope of this ticket.