Prototype

Comments and changes to this ticket

• 

  Juriy Zaytsev June 6th, 2008 @ 06:40 PM

  And what is stopping you from creating parent classes via Prototype?

• 

  John-David Dalton June 7th, 2008 @ 03:36 AM

  Could you please attach a patch to this ticket :)

  I don't know about this bug. I would like to hear what the core devs think.

  I can see this being "not for core".

• 

  Webbles June 7th, 2008 @ 05:47 AM

  Here's a diff.

  As for Juriy's question, nothing is stopping us. We have parent classes that are prototype based as well as parent classes that are YUI based. But when we try and extend a YUI class using the Prototype Class.create() method, we have to have this change. This is because YUI doesn't add the subclasses array to the objects and Prototype expects the parent object to have it.

  I'm not sure how I'd go about fixing this without modifying the code. I guess I could wrap the Class.create() function and do the check for the subclasses array in the wrapping function. I haven't tried that so I don't know if it will work.

  • diff 108 Bytes
• 

  Juriy Zaytsev June 7th, 2008 @ 06:13 AM

  Hmm, could you try if this works?

  Class.create = Class.create.wrap(function(proceed, parent) {
    if (Object.isFunction(parent))
      parent.subclasses = parent.subclasses || [];
    return proceed.apply(Class, $A(arguments).slice(1));
  })
  

• 

  Webbles June 9th, 2008 @ 07:05 PM

  That code worked great.

• 

  Andrew Dupont June 9th, 2008 @ 09:42 PM

  • → State changed from “new” to “not_for_core”