Prototype

Comments and changes to this ticket

• 

  Juriy Zaytsev April 15th, 2008 @ 07:01 PM

  How about just decodeURIComponent(encodeURIComponent(string)) ?

  This also affects getHeaderJSON, btw.

• 

  Alex Potsides April 15th, 2008 @ 07:19 PM

  Because it then fails the test case named 'proper decoding' with the message:

  expected <#<Hash:{'a b': 'c', 'd': 'e f', 'g': 'h'}>>, actual: <#<Hash:{'a%20b': 'c', 'd': 'e%20f', 'g': 'h'}>>
  

  Anyway, without wishing to sound rude, if you were going to do

  var key = decodeURIComponent(encodeURIComponent(string));
  

  you might as well just do

  var key = string;
  

• 

  Juriy Zaytsev April 15th, 2008 @ 07:44 PM

  Alex,

  but the point of such wrapping is to pass already encoded string into decodeURIComponent. I don't see how this is the same. Though, of course, I might be missing something.

• 

  Andrew Dupont April 15th, 2008 @ 09:47 PM

  How about

  var key = decodeURIComponent(string.gsub('%', encodeURIComponent));
  

  That'll do it, right?

• 

  Juriy Zaytsev April 15th, 2008 @ 09:59 PM

  Isn't gsub kindof unnecessary here?

  decodeURIComponent(string.replace(/%/g, encodeURIComponent))
  

• 

  Tobie Langel April 15th, 2008 @ 11:25 PM

  Juriy, afaik, some versions of safari don't support passing a method as a second argument to String#replace.

• 

  Alex Potsides April 16th, 2008 @ 10:09 AM

  I tried adding the above ideas to my local copy of Prototype and they both fail the unit test I pasted in the initial post.

  They both cause the 'proper decoding' unit test to fail with the message:

  Failure: proper decoding
  expected <#<Hash:{'a b': 'c', 'd': 'e f', 'g': 'h'}>>, actual: <#<Hash:{'a%20b': 'c', 'd': 'e%20f', 'g': 'h'}>>
  

  I suppose the problem is that the methods above indiscriminately encode all % symbols, rather than just ones that are not part of an encoded character.

  @Juriy

  If the process performed by encodeURIComponent is essentially the reverse of decodeURIComponent, then the action you suggest appears redundant.

  To break it out onto multiple lines:

  var string = "my string";
  string = encodeURIComponent(string); // "my%20string"
  string = decodeURIComponent(string); // "my string"
  

  Even with pre-encoded characters:

  var string = "my%20string";
  string = encodeURIComponent(string); // "my%2520string"
  string = decodeURIComponent(string); // "my%20string"
  
  // call it again for kicks
  string = decodeURIComponent(string); // "my string"
  

  Do you know of a case where this will not be true?

• 

  Tobie Langel April 16th, 2008 @ 10:22 PM

  • → Title changed from “[PATCH] [TEST] String.toQueryParams() not handling % properly” to “String.toQueryParams() not handling % properly”
  • → State changed from “new” to “enhancement_patch”
• 

  Tobie Langel April 18th, 2008 @ 01:16 PM

  • → State changed from “enhancement_patch” to “enhancement”
• 

  John-David Dalton May 29th, 2008 @ 04:48 AM

  • → Milestone changed from “” to “1.6.1”
  • → Assigned user changed from “” to “Juriy Zaytsev”