Element.Highlight bug?
Reported by Simon Harris | May 16th, 2008 @ 10:14 AM
passing an empty string "" for endcolor and/or restorecolor is treated as if nothing were passed in even though they are valid values for style. I've attached a patch.
Comments and changes to this ticket
-
Juriy Zaytsev May 16th, 2008 @ 11:28 AM
- → State changed from “new” to “bug”
I'd rather test for typeof != 'undefined'
if (!Object.isUndefined(this.options.endcolor)) { ... } -
Simon Harris May 16th, 2008 @ 06:11 PM
That sounds like a better solution. Great!
-
Simon Harris May 16th, 2008 @ 06:23 PM
Only I think it should be:
if (Object.isUndefined(this.options.endcolor)) {
...
}
-
Juriy Zaytsev May 16th, 2008 @ 06:53 PM
Yes, you're right
-
John-David Dalton May 28th, 2008 @ 10:28 PM
- → Assigned user changed from “” to “Thomas Fuchs”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
The Prototype JavaScript library.
Thomas Fuchs